Skip to content

Conversation

@liu381257974
Copy link
Contributor

API z_device_state_init has already defined in device.c

Signed-off-by: liuqian.andy liuqian.andyl@picoheart.com

@github-actions
Copy link

Hello @liu381257974, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

nashif
nashif previously approved these changes Nov 20, 2025
@nashif
Copy link
Member

nashif commented Nov 20, 2025

we probably should remove this from device.c and keep it in init.c, it is only being used in init.c

@liu381257974
Copy link
Contributor Author

we probably should remove this from device.c and keep it in init.c, it is only being used in init.c

Done .

peter-mitsis
peter-mitsis previously approved these changes Nov 20, 2025
API z_device_state_init has already defined in init.c

Signed-off-by: Liu Qian <liuqian.andy@picoheart.com>
@sonarqubecloud
Copy link

@liu381257974 liu381257974 requested a review from nashif November 24, 2025 03:10
@kartben kartben merged commit a2ca8b9 into zephyrproject-rtos:main Nov 24, 2025
43 of 47 checks passed
@github-actions
Copy link

Hi @liu381257974!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants